MatrixHB commented on code in PR #47:
URL:
https://github.com/apache/rocketmq-schema-registry/pull/47#discussion_r952402147
##########
client/src/main/java/org/apache/rocketmq/schema/registry/client/serde/json/JsonDeserializer.java:
##########
@@ -73,9 +90,7 @@ public T deserialize(String subject, byte[] payload) {
jsonNode = objectMapper.readValue(buffer.array(), start, length,
JsonNode.class);
Review Comment:
schemaRecordId seems useless in the method, because schema is already
obtained by subject.
Is there any plan to add the consistency check between recordID and the
obtained schema, or add method to deserialize totally by payload like T
deserialize(byte[] payload) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
