15712852007 commented on PR #4881: URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1226663708
> @15712852007 1, The synchronous path shall also be updated; 2, For async method, we should have a timer, helping to respect timeout specified by the method. For the async send, its workflow should be > > 1. client call async method; > 2. create a timeout timer; > 3. invoke async rpc; perform transparent retries if timeout is not reached; > 4. if RPC is successful within time frame, cancel the timer; if timeout timer fires, call callback with timeout; In my opinion, the introduction of timers may cause unnecessary waste of resources and may cause performance problems, we can make smaller and more reasonable designs based on the current version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
