MatrixHB commented on PR #53: URL: https://github.com/apache/rocketmq-schema-registry/pull/53#issuecomment-1233658490
> > @complone您好，非常感谢您贡献这个PR，但是在您进一步优化之前，我需要确认您是否对protobuf的兼容性验证有任何误解？ 这里所谓的兼容性验证关注的是兼容性，也就是比较更新后的protobuf schema和之前版本的protobuf schema，其变化是否会使得消息的生产和消费不兼容。 > > 但是，从你提交的代码来看，它似乎侧重于对字段、字段值范围、正则匹配等的验证。IMO，schema 注册中心并不打算涵盖这部分的逻辑，它更面向业务。 > > 如果是我不明白你的初衷，我们可以继续讨论。非常感谢。 > > By referring to Avro's verification logic, I found that protobuf does not have a related comparison API. In the process of avro own implementation, tracking the relevant details is to make a recursive comparison between the schema to be verified and the set of existing schemas. But the [generate method](https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/io/parsing/ResolvingGrammarGenerator.java#L53) is not reflected > > Thanks a lot for your suggestion here is what I misunderstood. I will try to make changes based on the information you provide @ferrirW Is schema registry suitable to cover the generate logic？ [generate method](https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/io/parsing/ResolvingGrammarGenerator.java#L53) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
