lizhanhui commented on code in PR #4637:
URL: https://github.com/apache/rocketmq/pull/4637#discussion_r961230135
##########
common/src/main/java/org/apache/rocketmq/common/PlainAccessConfig.java:
##########
@@ -99,4 +99,18 @@ public List<String> getGroupPerms() {
public void setGroupPerms(List<String> groupPerms) {
this.groupPerms = groupPerms;
}
+
+ @Override
+ public String toString() {
+ return "PlainAccessConfig{" +
Review Comment:
It is awkward and error-prone to manually concatenate strings. Why not use
JSON.toJsonString(this)?
Another thing, it would be better to omit the access secret part for safety
reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
