duhenglucky commented on code in PR #482:
URL: https://github.com/apache/rocketmq-spring/pull/482#discussion_r963311499
##########
rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/RocketMQUtil.java:
##########
@@ -326,4 +326,10 @@ public static DefaultLitePullConsumer
createDefaultLitePullConsumer(String nameS
return litePullConsumer;
}
+
+ public static String getNamespace(String specifiedNamespace, String
defaultNamespace) {
+ // prefer to use annotation namespace
+ // if is empty a default namespace will be used
+ return !StringUtils.hasLength(specifiedNamespace) &&
StringUtils.hasLength(defaultNamespace) ? defaultNamespace : specifiedNamespace;
Review Comment:
How about using the _isBlank_ method to avoid the influence brought by
whitespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
