ShadowySpirits commented on code in PR #5014:
URL: https://github.com/apache/rocketmq/pull/5014#discussion_r964484453
##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java:
##########
@@ -139,6 +138,12 @@ public static BrokerController
createBrokerController(String[] args) {
System.exit(-2);
}
+ if (!nettyServerConfig.getBindIP().equals("0.0.0.0") &&
+
!nettyServerConfig.getBindIP().equals(brokerConfig.getBrokerIP1())) {
Review Comment:
In the cloud environment, if public IP is assigned to one virtual network
interface, just set brokerIP1 and bindIP to public IP. More generally case is
cloud host use nat, which means you can not bind to public IP directly because
of OS limition.
<img width="641" alt="image"
src="https://user-images.githubusercontent.com/32436597/188814482-1b505bc1-a701-474c-85de-aa9c7d9c135d.png";>
In this case, you can set brokerIP1 to public IP and set bindIP to 0.0.0.0.
The same is true for binding to multiple network interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/32436597/188814482-1b505bc1-a701-474c-85de-aa9c7d9c135d.png"](https://user-images.githubusercontent.com/32436597/188814482-1b505bc1-a701-474c-85de-aa9c7d9c135d.png"){kind=link}