0902horn commented on code in PR #27:
URL:
https://github.com/apache/rocketmq-eventbridge/pull/27#discussion_r965451760
##########
adapter/api/src/main/java/org/apache/rocketmq/eventbridge/adapter/api/controller/ApiDestinationController.java:
##########
@@ -62,83 +64,137 @@ public class ApiDestinationController {
@WebLog
@PostMapping("createApiDestination")
- public CreateApiDestinationResponse createApiDestination(@RequestBody
CreateApiDestinationRequest createApiDestinationRequest) {
- final Set<ConstraintViolation<CreateApiDestinationRequest>> validate =
validator.validate(createApiDestinationRequest);
- List<String> errMessage =
validate.stream().map(ConstraintViolation::getMessage).collect(Collectors.toList());
- if (!CollectionUtils.isEmpty(errMessage)) {
- return new
CreateApiDestinationResponse(null).parameterCheckFailRes(errMessage.toString());
- }
- ApiDestinationDTO apiDestinationDTO =
getEventApiDestination(createApiDestinationRequest.getHttpApiParameters(),
createApiDestinationRequest.getDescription(),
createApiDestinationRequest.getConnectionName(),
createApiDestinationRequest.getInvocationRateLimitPerSecond(),
createApiDestinationRequest.getApiDestinationName(), accountAPI);
- return new
CreateApiDestinationResponse(apiDestinationService.createApiDestination(apiDestinationDTO)).success();
+ public Mono<CreateApiDestinationResponse> createApiDestination(
+ @RequestBody CreateApiDestinationRequest createApiDestinationRequest) {
+ return Mono.subscriberContext()
Review Comment:
Mono.subscriberContext seems to be deprecated according to this
[issue](https://github.com/reactor/reactor-core/issues/2572)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
