lizhanhui commented on code in PR #5033:
URL: https://github.com/apache/rocketmq/pull/5033#discussion_r966581191
##########
logging/src/main/java/org/apache/rocketmq/logging/dynamic/AbstractProcessUnitImpl.java:
##########
@@ -0,0 +1,116 @@
+package org.apache.rocketmq.logging.dynamic;
+
+import com.alibaba.fastjson.JSONArray;
+import com.alibaba.fastjson.JSONObject;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.logging.log4j.core.config.LoggerConfig;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.slf4j.impl.StaticLoggerBinder;
+
+import java.util.Enumeration;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+
+import static
org.apache.rocketmq.logging.dynamic.LogConstant.LOG4J2_LOGGER_FACTORY;
+import static
org.apache.rocketmq.logging.dynamic.LogConstant.LOG4J_LOGGER_FACTORY;
+import static
org.apache.rocketmq.logging.dynamic.LogConstant.LOGBACK_LOGGER_FACTORY;
+import static org.apache.rocketmq.logging.dynamic.LogConstant.LOGGER_LEVEL;
+import static org.apache.rocketmq.logging.dynamic.LogConstant.LOGGER_LIST;
+import static org.apache.rocketmq.logging.dynamic.LogConstant.LOGGER_NAME;
+import static
org.apache.rocketmq.logging.dynamic.LogConstant.LOGGER_TYPE_UNKNOWN;
+import static org.apache.rocketmq.logging.dynamic.LogConstant.LOG_FRAMEWORK;
+import static org.apache.rocketmq.logging.dynamic.LogConstant.ROOT_KEY;
+
+/**
+ * 日志调整抽象类
+ * 支持log4j、log4j2、logback
+ */
+public abstract class AbstractProcessUnitImpl implements IProcessUnit {
Review Comment:
Unlike C#, Interfaces in Java do not start with the prefix 'I'
conventionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
