RongtongJin commented on code in PR #5046:
URL: https://github.com/apache/rocketmq/pull/5046#discussion_r969049138
##########
broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java:
##########
@@ -303,8 +340,8 @@ private boolean registerBrokerToController() {
// Set isolated to false, make broker can register to namesrv
regularly
brokerController.setIsolated(false);
} else {
- LOGGER.warn("No master in controller");
- return false;
+ // if master address is empty, just apply the brokerId
+ this.brokerConfig.setBrokerId(registerResponse.getBrokerId());
Review Comment:
It would be better to verify the value of brokerId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
