echooymxq opened a new pull request, #5057: URL: https://github.com/apache/rocketmq/pull/5057
**Make sure set the target branch to `develop`** ## What is the purpose of the change * The others apis use `BrokerHeartbeatManager` just send heartbeat and check broker active status. The current implementation: The broker register to a controller leader and register the hearbeat manager, but if the controller leader is offlined, the other controller nodes havan't the broker heatbeat data and then `scanNotActiveBroker` become make no sense. Change points: remove ther heartbeat register api, register it with first heartbeat, and then every controller nodes will have the broker heartbeat. * Create a specified `BrokerControllerManager` to scan broker active health and switch master-slave. Redefine the `scanNotActiveBroker` logic, it will not scan every broker instance heartbeat, just check the specified master broker active, So i expose the `ReplicasInfoManager` the api, get the replicaInfoTable and loop it. ## Brief changelog XX ## Verifying this change XXXX Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
