RongtongJin commented on code in PR #5093:
URL: https://github.com/apache/rocketmq/pull/5093#discussion_r973534037
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -1629,22 +1629,33 @@ private boolean isTempFileExist() {
return file.exists();
}
- private void recover(final boolean lastExitOK) {
- long recoverCqStart = System.currentTimeMillis();
- long maxPhyOffsetOfConsumeQueue = this.recoverConsumeQueue();
- long recoverCqEnd = System.currentTimeMillis();
+ private boolean recover(final boolean lastExitOK, final boolean
recoverConcurrently) {
Review Comment:
How about keeping the original function signature？ We can also get the
brokerConfig in the recover function.
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -1629,22 +1629,33 @@ private boolean isTempFileExist() {
return file.exists();
}
- private void recover(final boolean lastExitOK) {
- long recoverCqStart = System.currentTimeMillis();
- long maxPhyOffsetOfConsumeQueue = this.recoverConsumeQueue();
- long recoverCqEnd = System.currentTimeMillis();
+ private boolean recover(final boolean lastExitOK, final boolean
recoverConcurrently) {
Review Comment:
How about keeping the original function signature？ We can also get the
brokerConfig in the recover function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
