lizhiboo opened a new issue, #321:
URL: https://github.com/apache/rocketmq-connect/issues/321

   WorkerSourceTask.java
   ```java
   Future<Void> flushFuture = positionStorageWriter.doFlush((error, key, 
result) -> {
               if (error != null) {
                   log.error("{} Failed to flush offsets to storage: ", 
WorkerSourceTask.this, error);
               } else {
                   log.trace("{} Finished flushing offsets to storage", 
WorkerSourceTask.this);
               }
           });
           try {
               flushFuture.get(Math.max(timeout - System.currentTimeMillis(), 
0), TimeUnit.MILLISECONDS);
           }
   ```
   WorkerSourceTask.commitOffsets will be called sync at each message, it's 
harmful to performance. IMO, we can use async to commitOffset.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to