Knowden commented on issue #5162: URL: https://github.com/apache/rocketmq/issues/5162#issuecomment-1255741566
> For some pulled messages for maxMsgNums could be filter-out. so `Message Count ` is not a good way to limit. Change Count-Limit to Bytes-Limit, you can check code on 4.9.x. > > https://github.com/apache/rocketmq/blob/c88686f13e6f4acef1f00c6d3e18589683ec3368/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java#L623 > > but it seems need some updates on > > ```java > if ((cqUnit.getQueueOffset() - offset) * CQ_STORE_UNIT_SIZE > maxFilterMessageCount) { > break; > } > ``` ok. I will submit a PR to fix this later on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
