lizhanhui commented on code in PR #5171:
URL: https://github.com/apache/rocketmq/pull/5171#discussion_r978422367
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -764,7 +764,7 @@ public GetMessageResult getMessage(final String group,
final String topic, final
boolean isInDisk =
checkInDiskByCommitOffset(offsetPy, maxOffsetPy);
- if (cqUnit.getQueueOffset() - offset >
maxFilterMessageCount) {
+ if ((cqUnit.getQueueOffset() - offset) *
ConsumeQueue.CQ_STORE_UNIT_SIZE > maxFilterMessageCount) {
Review Comment:
count-based comparison is more understandable. If there are
implementation-specific subtle differences, there should be a concept to
abstract away from them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
