RapperCL opened a new issue, #5179:
URL: https://github.com/apache/rocketmq/issues/5179
1 Math.abs() method call redundant
The incrementAndGet method of ThreadLocalIndex has made the absolute
value of the returned result. When acquiring externally, there is no need to
add the abs method.
At present, there are inconsistencies in the processing of calling
this method in the project. In some places, there is no additional absolute
value, and in some places, the abs method is additionally added.
for example:
Where additionally the Math.abs() method is added：
Where the Math.abs() method is not additionally
added：
2 redundant judgment
pos will not be less than 0
3 repeated assignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
