Oliverwqcwrw commented on code in PR #318:
URL: https://github.com/apache/rocketmq-connect/pull/318#discussion_r979367913
##########
connectors/rocketmq-connect-cassandra/src/main/java/org/apache/rocketmq/connect/cassandra/connector/CassandraSinkConnector.java:
##########
@@ -179,62 +183,35 @@ public void buildRoute() {
}
} catch (Exception e) {
log.error("Fetch topic list error.", e);
- } finally {
- // srcMQAdminExt.shutdown();
}
}
+
/**
* We need to reason why we don't call srcMQAdminExt.shutdown() here, and
why
* it can be applied to srcMQAdminExt
*/
@Override
public void stop() {
listenerHandle.cancel(true);
- // srcMQAdminExt.shutdown();
}
- @Override
- public void pause() {
- }
-
- @Override
- public void resume() {
-
- }
@Override
public Class<? extends Task> taskClass() {
return CassandraSinkTask.class;
}
@Override
- public List<KeyValue> taskConfigs() {
+ public List<KeyValue> taskConfigs(int maxTasks) {
log.info("List.start");
if (!configValid) {
return new ArrayList<KeyValue>();
}
-
- startMQAdminTools();
-
- buildRoute();
-
- TaskDivideConfig tdc = new TaskDivideConfig(
- this.dbConnectorConfig.getDbUrl(),
- this.dbConnectorConfig.getDbPort(),
- this.dbConnectorConfig.getDbUserName(),
- this.dbConnectorConfig.getDbPassword(),
- this.dbConnectorConfig.getLocalDataCenter(),
- this.dbConnectorConfig.getConverter(),
- DataType.COMMON_MESSAGE.ordinal(),
- this.dbConnectorConfig.getTaskParallelism(),
- this.dbConnectorConfig.getMode()
- );
-
- ((SinkDbConnectorConfig)
this.dbConnectorConfig).setTopicRouteMap(topicRouteMap);
-
- return
this.dbConnectorConfig.getTaskDivideStrategy().divide(this.dbConnectorConfig,
tdc);
+ List<KeyValue> list = new ArrayList<>();
+ list.add(this.keyValue);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
