Oliverwqcwrw commented on code in PR #5062:
URL: https://github.com/apache/rocketmq/pull/5062#discussion_r979488874
##########
broker/src/main/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageBridge.java:
##########
@@ -346,4 +346,16 @@ public MessageExt lookMessageByOffset(final long
commitLogOffset) {
public BrokerController getBrokerController() {
return brokerController;
}
+
+ public boolean escapeMessage(MessageExtBrokerInner messageInner) {
+ PutMessageResult putMessageResult =
this.brokerController.getEscapeBridge().putMessage(messageInner);
+ if (putMessageResult != null
Review Comment:
how about use `org.apache.rocketmq.store.PutMessageResult#isOk` to verify
whether success,
It's a little bit cleaner and it's consistent with everything else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
