xdkxlk commented on code in PR #5161:
URL: https://github.com/apache/rocketmq/pull/5161#discussion_r979522995
##########
common/src/main/java/org/apache/rocketmq/common/protocol/header/EndTransactionRequestHeader.java:
##########
@@ -128,4 +130,12 @@ public String toString() {
", transactionId='" + transactionId + '\'' +
Review Comment:
The new fields need to be added into toString
##########
common/src/main/java/org/apache/rocketmq/common/protocol/header/CheckTransactionStateRequestHeader.java:
##########
@@ -20,18 +20,19 @@
*/
package org.apache.rocketmq.common.protocol.header;
-import org.apache.rocketmq.remoting.CommandCustomHeader;
+import org.apache.rocketmq.common.rpc.RpcRequestHeader;
import org.apache.rocketmq.remoting.annotation.CFNotNull;
import org.apache.rocketmq.remoting.exception.RemotingCommandException;
-public class CheckTransactionStateRequestHeader implements CommandCustomHeader
{
+public class CheckTransactionStateRequestHeader extends RpcRequestHeader {
@CFNotNull
private Long tranStateTableOffset;
@CFNotNull
private Long commitLogOffset;
private String msgId;
private String transactionId;
private String offsetMsgId;
+ private int queueId;
Review Comment:
The CheckTransactionStateRequestHeader is sent by broker. I think we should
change the
org.apache.rocketmq.broker.client.net.Broker2Client#checkProducerTransactionState
to set the new fileds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
