2011shenlin commented on code in PR #5123:
URL: https://github.com/apache/rocketmq/pull/5123#discussion_r979905246


##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java:
##########
@@ -271,6 +290,83 @@ public void run() {
 
     }
 
+    private Map.Entry<String, SocksProxyConfig> getProxy(String addr) {
+        String[] addrArr = addr.split(":");
+        for (Map.Entry<String, SocksProxyConfig> entry : proxyMap.entrySet()) {
+            String cidr = entry.getKey();
+            if (RemotingHelper.ipInCIDR(addrArr[0], cidr)) {

Review Comment:
    Do not have supportted the domain name. It seems miss some codes..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to