lizhanhui commented on code in PR #5244:
URL: https://github.com/apache/rocketmq/pull/5244#discussion_r990756918
##########
example/src/main/java/org/apache/rocketmq/example/benchmark/timer/TimerConsumer.java:
##########
@@ -151,6 +166,30 @@ private Options buildCommandlineOptions(Options options) {
opt.setRequired(false);
options.addOption(opt);
+ opt = new Option("w", "threadCount", true, "Thread count, Default:
20");
+ opt.setRequired(false);
+ options.addOption(opt);
+
+ opt = new Option("m", "msgTraceEnable", true, "Message Trace Enable,
Default: false");
+ opt.setRequired(false);
+ options.addOption(opt);
+
+ opt = new Option("g", "group", true, "Consumer group name, Default:
benchmark_consumer");
+ opt.setRequired(false);
+ options.addOption(opt);
+
+ opt = new Option("a", "aclEnable", true, "Acl Enable, Default: false");
+ opt.setRequired(false);
+ options.addOption(opt);
+
+ opt = new Option("ak", "accessKey", true, "Acl access key, Default:
rocketmq2");
Review Comment:
Having defaults for access key/secret might not be a good idea. If access
control is enabled, best to check required credentials are properly provided
and warn neatly if something is missing or wrong, instead of using default
ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
