[GitHub] [rocketmq-eventbridge] 2011shenlin commented on a diff in pull request #35: update connection

[GitBox]

2011shenlin commented on code in PR #35:
URL: 
https://github.com/apache/rocketmq-eventbridge/pull/35#discussion_r994319148


##########
domain/src/main/java/org/apache/rocketmq/eventbridge/domain/model/connection/ConnectionService.java:
##########
@@ -154,18 +163,12 @@ private AuthParameters setSecretData(AuthParameters 
authParameters, String accou
         final ApiKeyAuthParameters apiKeyAuthParameters = 
authParameters.getApiKeyAuthParameters();
         final OAuthParameters oauthParameters = 
authParameters.getOauthParameters();
         if (basicAuthParameters != null) {
-            Map<String, String> basicAuthParametersMap = Maps.newHashMap();
-            basicAuthParametersMap.put("username", 
basicAuthParameters.getUsername());
-            basicAuthParametersMap.put("password", 
basicAuthParameters.getPassword());
-            final String secretName = 
secretManagerAPI.createSecretName(accountId, connectionName, new 
Gson().toJson(basicAuthParametersMap));
+            final String secretName = 
secretManagerAPI.createSecretName(accountId, connectionName, new 
Gson().toJson(basicAuthParameters));
             basicAuthParameters.setPassword(secretName);

Review Comment:
   Why secretName convert to  password? where is the userName?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org