leizhiyuan commented on code in PR #101:
URL: https://github.com/apache/rocketmq-docker/pull/101#discussion_r1496833074


##########
stage.sh:
##########
@@ -51,4 +51,13 @@ cp -rf "$CURRENT_DIR/templates/" "$STAGE_DIR/$version"
 echo "staged templates into folder $STAGE_DIR/$version"
 
 # Replace string "ROCKETMQ_VERSION" with real version in all files under 
$STAGE_DIR/$version
-find "$STAGE_DIR/$version" -type f | xargs perl -pi -e 
"s/ROCKETMQ_VERSION/${version}/g"
\ No newline at end of file
+find "$STAGE_DIR/$version" -type f | xargs perl -pi -e 
"s/ROCKETMQ_VERSION/${version}/g"
+
+
+if [[ "${version}" > "5.0.0" ]]; then

Review Comment:
   rmq5 也可以不使用 proxy,单独部署broker。这里后续相当于只要5.x以上的,docker 
compose。就有proxy对吧。用户根据自己的需求,连接proxy/ns 来实现不同的case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to