GitHub user somak2kai created a discussion: Requesting CI execution permission and review of a small bug fix PR https://github.com/apache/rocketmq/pull/10631
Hi all, I'd like to bring attention to a small bugfix PR that's ready for review but appears to be waiting on a committer to trigger CI (I understand this is standard for first-time contributors): PR: https://github.com/apache/rocketmq/pull/10631 Issue: https://github.com/apache/rocketmq/issues/10630 Summary: DefaultLitePullConsumerImpl.taskTable is mutated by three methods (updatePullTask, updateAssignPullTask, removePullTask) via a non-atomic check-then-act sequence (containsKey then put in startPullTask), with no synchronization. The fix wraps the three mutating methods in synchronized (this.taskTable), mirroring the locking pattern already used by the sibling AssignedMessageQueue class. Included a test (DefaultLitePullConsumerImplTaskTableRaceTest) that reproduces the race pre-fix and passes post-fix. Automated review has already gone over the change. Would appreciate it if a committer could take a look and kick off CI when convenient — happy to address any feedback. GitHub link: https://github.com/apache/rocketmq/discussions/10749 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
