[GitHub] incubator-rocketmq issue #4: Null check is not needed -- can't be null when ...

[nottyjay]

Github user nottyjay commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/4
  
    I see, the best unit test is 
`com.alibaba.rocketmq.example.quickstart.Producer` which in Model 
`rocketmq-example`.
    Delete these codes because in `Validators.checkGroup(String group)`，it 
calls `UtilAll.isBlank(group)` to check group. So, in 
`DefaultMQProducerImpl`， null check is not needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---