Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/20#discussion_r94042593
--- Diff:
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -191,7 +199,7 @@ public long howMuchFallBehind() {
return 0;
}
- public MappedFile getLastMappedFile(final long startOffset, boolean
needCreate) {
+ private MappedFile getLastMappedFile(final long startOffset, boolean
needCreate) {
--- End diff --
Yes, some methods in `MappedFileQueue` may have their access modifier
narrowed down in grammatical, but I think these methods should be `public`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
