Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/31#discussion_r95059881
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -1045,7 +1045,7 @@ public void run() {
while (!this.isStopped()) {
try {
- this.waitForRunning(0);
+ this.waitForRunning(1000);
--- End diff --
I also think `waitForRunning(0)` is too rigorous, but
`waitForRunning(1000)` is adventurous while the `GroupCommitService` may miss
some notify signals.
How about set a smaller wait time, like 10ms? what's your opinion ?
@qinliujie
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
