Github user zhouxinyu commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/39#discussion_r95964644
  
    --- Diff: 
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
    @@ -397,11 +397,21 @@ public int deleteExpiredFileByOffset(long offset, int 
unitSize) {
                             log.info("physic min offset " + offset + ", logics 
in current mappedFile max offset "
                                 + maxOffsetInLogicQueue + ", delete it");
                         }
    +                } else if (!mappedFile.isAvailable()) { // Handle hanged 
file.
    --- End diff --
    
    When MappedFile has been `shutdown`, no more new holder appear, so the 
`RefCount` will to be 0 soon, so I think maybe it's more graceful :)..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to