Github user lizhanhui commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/33#discussion_r95966853
  
    --- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java ---
    @@ -53,8 +53,9 @@ public MQClientInstance 
getAndCreateMQClientInstance(final ClientConfig clientCo
                 MQClientInstance prev = 
this.factoryTable.putIfAbsent(clientId, instance);
                 if (prev != null) {
                     instance = prev;
    -            } else {
                     log.warn("Previous MQClientInstance has created for 
clientId:[{}]", clientId);
    +            } else {
    +                log.info("new MQClientInstance has created for 
clientId:[{}]", clientId);
    --- End diff --
    
    It will be best if using active tune here.  Something like, Returned 
previous MQClientInstance for clientId: ..., Created new MQClientInstance for 
clientId: ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to