GitHub user shroman opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/49

    [ROCKETMQ-72] DefaultMessageStore cannot be properly shutdown when fa…

    …iled in the middle of start()
    
    JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-72
    
    Setting `shutdown` to `false` doesn't seem semantically very correct to me, 
but without it, message store cannot be properly shutdown.
    Please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-72

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #49
    
----
commit 2b15a5a72c16aa82070f940cf7d329a7460a2c92
Author: shtykh_roman <[email protected]>
Date:   2017-01-23T11:27:00Z

    [ROCKETMQ-72] DefaultMessageStore cannot be properly shutdown when failed 
in the middle of start()
    
    JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-72

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to