Hi, For the first issue, aka, moving org.apache.rocketmq.client.exception from client module to common module, I agree with Jiang.
For the latter one, that is, supporting JDK as lower as possible, I think differently. 1) Maintaining lower JDK compatibility imposes potentially fewer constraints for application developers, as is obviously beneficial to the diverse community 2) For common and client modules, there is no must-have features that exclusively exist in JDK 7+; JDK 5, IMHO, should be fine. Zhanhui Li. > 在 2017年1月30日,上午7:56,Willem Jiang <[email protected]> 写道: > > If think MQBrokerException could only be used on the client side, it's not > a part of rocketmq broker. We don't need to move the MQBrokerException. > > I think it's a good suggestion to keep RocketMQ working with lower version > of JDK. But it could a community decision which version of JDK we should > support. I just have a quick look at the current trunk code. The JDK > compile source and target are 1.7, it makes sense that we are not support > JDK 1.6 any more. > > Willem Jiang > > Blog: http://willemjiang.blogspot.com (English) > http://jnn.iteye.com (Chinese) > Twitter: willemjiang > Weibo: 姜宁willem > > 2017-01-26 11:10 GMT+08:00 <[email protected]>: > >> >> >> 建议将MQBrokerException从org.apache.rocketmq.client.exception调整到org.apache. >> rocketmq.common.exception下。去除broker对client的依赖。 >> >> >> >> 建议降低client对jdk版本的要求。毕竟各个应用客户端升级jdk的成本比较大。 >> >>
