Hi, My sincere apology for these two closed pull requests without adequate explanations, as zhanhui said, we are deeply appreciating efforts/contributions from community without any doubt.
And I think we should improve the PR closing process and add the result to this doc[1], below questions need discussions: 1. When we can close a PR? 2. Who perform the closing operations? Committers or the PR author? 3. If committers do the closing operations, how? With an empty commit or other way? And as Justin said, committers should accept and fix the defective issue rather than rejecting or asking the contributor to make it perfect, actually we don't know we have change permissions about PR, so we always guide contributors step by step to make PR better. [1] http://rocketmq.incubator.apache.org/docs/pull-request/ Happy Chinese New Year, yukon On Mon, Jan 30, 2017 at 11:46 AM, Justin Mclean <[email protected]> wrote: > Hi, > > I don't see a huge concern here but more conversation and more detailed > reasons for closing PR is always good. Helping contributors getting their > PRs into shape is even better. Even if a PR needs a little work, it could > be accepted and fixed by an existing committer rather than rejected or > asking the contributor to make it perfect. > > Thanks, > Justin
