Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
@dongeforever yes, I think we have to discuss it in the dev mailing list
:+1:
I think having a class/methods for wire protocol version checking and
applying them (and, as a result, accepting or rejecting) when a client wants to
establish a connection to a broker, etc. should work. I guess that's what you
meant by having "checking codes in one place" :)
The version information can be placed into headers.
Such protocol changes shouldn't happen that often (RocketMQ v.4.0.0,
v.4.1.0 may use protocol v.1, but RocketMQ v.5.0.0 may use protocol v.2), but
if they happen, in this way we can guarantee that the communication between
system components is done correctly.
Let's discuss it in the ml. My understanding of RocketMQ is still not
complete ;) Maybe there are better ideas not to over-complicate is with
versioning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
