+1 (binding)

maven compile and test passed
checked MD5 and signatures
readme/license and others looks good.

-Env: MacOS + JDK8

Thanks.


Best Regards!
---------------------

Luke Han

On Thu, Feb 16, 2017 at 9:34 AM, Willem Jiang <[email protected]>
wrote:

> +1 (binding)
>
> I checked
> - signatures and signed the artifacts
> - The nexus staging artifacts are good, I used the example to verify the
> artifacts can be downloaded.
> - README looks good
> - No unexpected binary files in release
> - The source can be compile and all tests are passed
>
> There is a minor issue that I found.
> The binary artifact extract directory doesn't has incubating in the name (
> it's apache-rocketmq-all)
>
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
>           http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Sun, Feb 12, 2017 at 11:44 AM, yukon <[email protected]> wrote:
>
> > Hello RocketMQ Community,
> >
> > This is the vote for 4.0.0 of Apache RocketMQ (incubating).
> >
> > The RC3 artifacts:
> > https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.
> > 0.0-incubating-rc3/
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-rocketmq/tree/
> > rocketmq-4.0.0-incubating
> >
> > Hash for the release tag:
> > dddc3daa2cbec4c7240d6525d2ce198826d29967
> >
> > Release Notes:
> > http://rocketmq.incubator.apache.org/release_notes/release-
> > notes-4.0.0-incubating/
> >
> > The artifacts have been signed with Key : E9BDDB0E, which can be found in
> > the keys file:
> > https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
> >
> > The maven release artifacts:
> > https://repository.apache.org/content/repositories/orgapacherocketmq-100
> > <https://repository.apache.org/content/repositories/
> orgapacherocketmq-1002
> > >3
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Here is my +1
> >
> > Thanks,
> > The Apache RocketMQ Team
> >
>

Reply via email to