Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/57#discussion_r101455998
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -567,6 +577,11 @@ public PutMessageResult putMessage(final
MessageExtBrokerInner msg) {
MappedFile unlockMappedFile = null;
MappedFile mappedFile = this.mappedFileQueue.getLastMappedFile();
+ //maybe need to wrap the exception
--- End diff --
When encoding fails, let's notify a user with a `PutMessageResult` about
the failure. There's nothing else we can do, I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
