+1 Completely agree with Roman, Sometimes it's hard to understand the functionality of methods in codebase.
On Wed, Feb 22, 2017 at 1:48 PM, Roman Shtykh <[email protected]> wrote: > Folks, > The current codebase has too few comments and not so many unit tests, and > therefore it is pretty hard to understand the intentions of developers on > their code (and figure out if a fix/improvement is needed, and so on). > I realize we cannot start commenting on all the code now, but how about > accepting pull requests only if all newly-introduced or significantly > modified public methods and classes have informative Javadoc comments, in > addition to unit tests, where applicable?Writing comments on the code you > understand is pretty easy, and it saves some time to others. > Roman > -- Chandresh Pancholi Senior Software Engineer Flipkart.com Email-id:[email protected] Contact:08951803660
