Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/64#discussion_r102897821 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java --- @@ -92,10 +92,22 @@ public void run() { } } - public void shutdown() { + @Override + public void shutdown(long awaitTerminateMillis) { this.stopped = true; this.scheduledExecutorService.shutdown(); this.consumeExecutor.shutdown(); + //await to consume + if (awaitTerminateMillis > 0) { + try { + this.consumeExecutor.awaitTermination(awaitTerminateMillis,TimeUnit.MILLISECONDS); + if (!this.consumeExecutor.isTerminated()) log.info("There are messages still being consumed in thread pool, but not going to await them anymore. Have awaited for {} ms",awaitTerminateMillis); --- End diff -- We can, but where do we put this method in, in a Common Util?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---