[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

[dongeforever]

Github user dongeforever commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/53#discussion_r104348323
  
    --- Diff: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java 
---
    @@ -331,7 +331,7 @@ public long getMinOffsetInQueue() {
         public void putMessagePositionInfoWrapper(long offset, int size, long 
tagsCode, long storeTimestamp,
             long logicOffset) {
             final int maxRetries = 30;
    -        boolean canWrite = 
this.defaultMessageStore.getRunningFlags().isWriteable();
    +        boolean canWrite = 
this.defaultMessageStore.getRunningFlags().isCQWriteable();
    --- End diff --
    
    @Jaskey Yeah, it is better to use the name isConsumeQWritable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---