Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
@vongosling I meant "If I were you, I would ..." :) Anyway, I don't see why
this pr can be merged if a unit test can be easily written. I think we have to
accept PRs with tests, except for the cases when they cannot be implemented.
Ok, then let's close this pr? and tests can be submitted in another one.
@yilingfeng I have a quick look, and here is what I think.
Better name the file `MessageClientIDSetterTest.java` and have tests for
`getNearlyTimeFromID()` etc. instead of implementing another method in your
unit test class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
