Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/60#discussion_r105590475
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java
---
@@ -46,7 +46,7 @@
private final TreeMap<Long, MessageExt> msgTreeMap = new TreeMap<Long,
MessageExt>();
private final AtomicLong msgCount = new AtomicLong();
private final Lock lockConsume = new ReentrantLock();
- private final TreeMap<Long, MessageExt> msgTreeMapTemp = new
TreeMap<Long, MessageExt>();
+ private final TreeMap<Long, MessageExt> consumingMsgOrderlyTreeMap =
new TreeMap<Long, MessageExt>();//subset of msgTreeMap, used when consume
orderly
--- End diff --
It would be nice to have a Javadoc comment here. Something like,
```java
/**
* Subset of msgTreeMap used when consuming orderly.
*/
private final TreeMap<Long, MessageExt> msgOrderlyTreeMap = ...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---