Github user Jaskey commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/75
  
    Do you guys really consider that is good enough?? @vongosling @lollipopjin 
    
    IMO, the origin design is OK, since the AuthenticationException is thrown 
from the hook.
    
    The devs will log their own Authentication fail log already (may be print 
periodically or somehow ), but rocketmq remoting should only care about the 
real error.
    
    If we remove it, all authentication fail will have one log, and this could 
be possibly  very often and fill up with the remoting log, which I do not think 
it is good enough. 
    
    User should care about their custom authentication log, and remoting 
component should care about real error thrown from the processor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to