Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524663
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import org.apache.rocketmq.common.message.Message;
-public interface LocalTransactionExecuter {
- public LocalTransactionState executeLocalTransactionBranch(final
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --
This is why I make these changes thorough PR process instead of regarding
them trivial and merging directly.
We can discuss to figure out an acceptable way.
You may also notice that I do not change configuration name spelling issues
yet and I am expecting opinions too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
