Github user Jaskey commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/86
  
    @shroman 
    
    For your first point, I would like to remain the existing flow? Because the 
heart beat sent may be failed and if we only mark the success one, we maybe 
miss the log for long turn when send heartbeat is failed for many times and 
then become success.  But anyway this is a minor issue , I will follow your 
advice if you guys think it is better.
    
    For your second point, I agree and I will proceed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to