Github user lizhanhui commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/95
  
    Thanks @Jaskey, this is indeed a good place to improve. 
    
    For the implementation, I suggest an alternative generic way, instead of 
add a close future for each request, we add the opaque integer into a 
collection per channel. Remove the opaque integer on response or invalidate all 
of them in NettyConnectManageHandler. Suggested approach has fewer memory 
footprint and we may also easily cover the sync request scenario -- respond 
earlier before `timeoutMillis` amount of time elapsed in case channel 
experiences problems.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to