Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/104#discussion_r117158804
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -339,6 +339,8 @@ public static void properties2Object(final Properties
p, final Object object) {
String key = first.toLowerCase() + tmp;
String property = p.getProperty(key);
if (property != null) {
+ // remove spaces before and after
--- End diff --
what about we also trim the method `public static String
properties2String(final Properties properties)` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
