Github user lindzh commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/120#discussion_r123936939
  
    --- Diff: client/pom.xml ---
    @@ -37,13 +37,31 @@
                 <groupId>${project.groupId}</groupId>
                 <artifactId>rocketmq-common</artifactId>
             </dependency>
    +
             <dependency>
                 <groupId>org.slf4j</groupId>
                 <artifactId>slf4j-api</artifactId>
             </dependency>
    +
             <dependency>
                 <groupId>org.apache.commons</groupId>
                 <artifactId>commons-lang3</artifactId>
             </dependency>
    +
    +        <dependency>
    +            <groupId>org.apache.logging.log4j</groupId>
    +            <artifactId>log4j-core</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.logging.log4j</groupId>
    +            <artifactId>log4j-api</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.logging.log4j</groupId>
    +            <artifactId>log4j-slf4j-impl</artifactId>
    --- End diff --
    
    As log4j is widely used in example,add this test in example will make it 
confused to choose log moudle.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to