Github user Jaskey commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/127#discussion_r124174720
  
    --- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
 ---
    @@ -273,6 +273,17 @@ public void pullMessage(final PullRequest pullRequest) 
{
             final long beginTimestamp = System.currentTimeMillis();
     
             PullCallback pullCallback = new PullCallback() {
    +
    +            private void scheduleNextPull(PullResult pullResult) {
    --- End diff --
    
    what about renaming the method to `correctTagsOffsetAndSchedulePull` since 
this method is called by the result which needs to correct tags offset before 
schedule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to