Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130526510
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -745,17 +751,7 @@ public long getMessageStoreTimeStamp(String topic, int
queueId, long consumeQueu
ConsumeQueue logicQueue = this.findConsumeQueue(topic, queueId);
if (logicQueue != null) {
SelectMappedBufferResult result =
logicQueue.getIndexBuffer(consumeQueueOffset);
- if (result != null) {
- try {
- final long phyOffset =
result.getByteBuffer().getLong();
- final int size = result.getByteBuffer().getInt();
- long storeTime =
this.getCommitLog().pickupStoreTimestamp(phyOffset, size);
- return storeTime;
- } catch (Exception ignored) {
- } finally {
- result.release();
- }
- }
+ long storeTime = getStoreTime(result);
--- End diff --
We appreciate your contribution for rocketmq commuity, could you use unit
test to verify your refactoring
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
