Github user shroman commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/140#discussion_r132087129
  
    --- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/body/RegisterBrokerBody.java
 ---
    @@ -40,4 +57,114 @@ public void 
setTopicConfigSerializeWrapper(TopicConfigSerializeWrapper topicConf
         public void setFilterServerList(List<String> filterServerList) {
             this.filterServerList = filterServerList;
         }
    +
    +    public byte[] encode(boolean compress) {
    +
    +        if (!compress) {
    +            return encode();
    +        }
    +
    +        ByteArrayOutputStream byteArrayOutputStream = new 
ByteArrayOutputStream();
    +        DeflaterOutputStream outputStream = new 
DeflaterOutputStream(byteArrayOutputStream, new 
Deflater(Deflater.BEST_COMPRESSION));
    --- End diff --
    
    I think `Deflater.BEST_COMPRESSION` may be even slower than GZIP. Do we 
care about compression speed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to