Github user dongeforever commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/126#discussion_r132427103
  
    --- Diff: 
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
    @@ -45,19 +47,22 @@ public void init() throws Exception {
             BornHost = new 
InetSocketAddress(InetAddress.getByName("127.0.0.1"), 0);
         }
     
    +    public MessageStore buildMessageStore() throws Exception {
    +        MessageStoreConfig messageStoreConfig = new MessageStoreConfig();
    +        messageStoreConfig.setMapedFileSizeCommitLog(1024 * 1024 * 10);
    +        messageStoreConfig.setMapedFileSizeConsumeQueue(1024 * 1024 * 10);
    +        messageStoreConfig.setMaxHashSlotNum(10000);
    +        messageStoreConfig.setMaxIndexNum(100 * 100);
    +        messageStoreConfig.setFlushDiskType(FlushDiskType.ASYNC_FLUSH);
    +        return new DefaultMessageStore(messageStoreConfig, new 
BrokerStatsManager("simpleTest"), new MyMessageArrivingListener(), new 
BrokerConfig());
    --- End diff --
    
    The MessageStore uses the default store path(~/store).
    And the test forgets to delete files in that path.
    Two suggestions:
    1. create temp path, and set it as storePath
    2. delete all the files after the testing



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to