Github user shroman commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132808594
  
    --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
    @@ -59,7 +59,7 @@
         public static final String WS_DOMAIN_NAME = 
System.getProperty("rocketmq.namesrv.domain", DEFAULT_NAMESRV_ADDR_LOOKUP);
         public static final String WS_DOMAIN_SUBGROUP = 
System.getProperty("rocketmq.namesrv.domain.subgroup", "nsaddr");
     //    // http://jmenv.tbsite.net:8080/rocketmq/nsaddr
    -//    public static final String WS_ADDR = "http://"; + WS_DOMAIN_NAME + 
":8080/rocketmq/" + WS_DOMAIN_SUBGROUP;
    +    public static final String WS_ADDR = "http://"; + WS_DOMAIN_NAME + 
":8080/rocketmq/" + WS_DOMAIN_SUBGROUP;
    --- End diff --
    
    Is it legal to bring `WS_ADDR`? It was commented out for a reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to